fix: Allow src and href attributes to also be numbers #2835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
link
annotation, we can see that numbers are accepted to allow linking directly to page numbers.react-pdf/packages/pdfkit/src/mixins/annotations.js
Line 57 in 3f5bf67
This PR updates the type definitions of the
src
andhref
attribute on theLink
component to allow passing in page numbers.