Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculate x position of tspan elements without explicit x prop #2961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klingebiel-sii
Copy link

Fixes #2931

If the x attribute of a <tspan> has not been defined explicitly, the current behavior causes the each <tspan> to inherit the x value of it's parent <text> element.

<Svg>
    <Text x="10" y="30">
        <Tspan>One</Tspan>
        <Tspan>Two</Tspan>
        <Tspan>Three</Tspan>
    </Text>
</Svg>

Is:
image

Should:
image

This PR fixes this issue by...

  • resetting the inherited x value to the original x value of the <tspan>
  • aggregating an offset for each children of a <text> node and using it as the child node's x value, if necessary

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: a6cf9f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tspan inside if Text Element is broken
1 participant