Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jglauber/fixes #23

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Jglauber/fixes #23

merged 3 commits into from
Apr 16, 2024

Conversation

el8
Copy link
Contributor

@el8 el8 commented Apr 16, 2024

Some minor fixes to allow running vmtop on more systems (non-NUMA) and improve error messages.

Should fix issue #21 and #22

Jan Glauber added 3 commits April 16, 2024 16:45
Signed-off-by: Jan Glauber <[email protected]>
And fail with more descriptive error.

Signed-off-by: Jan Glauber <[email protected]>
While vmtop might be geared towards NUMA systems it can show
steal times also on non-NUMA systems.

Signed-off-by: Jan Glauber <[email protected]>
Copy link
Collaborator

@mpontillo mpontillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

nit: I think we should be printing errors to stderr, but that seems to be a larger change than the scope of this PR.

@el8 el8 merged commit ae0a19e into master Apr 16, 2024
1 check passed
@mpontillo mpontillo deleted the jglauber/fixes branch April 16, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants