Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New feature - "Hide Original Language when Translated" #955

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

pelmeniboiler
Copy link
Contributor

Hi, I hope it's okay to not use the issue template for this, I felt it was slightly different from a traditional feature request.

  • Sick of the mess created by effectively doubling the size of every tweet when you use auto-translate?
  • Want to force yourself into finally learning how to read Devanagari through total immersion?
  • Just tired of English and its all-encompassing universality and want to step back?

Presenting: "Hide original language when translated"

image

image

It just sits in the translate scripts, checks whether the user ticked its box in settings, then overwrites the original text after it's done being used by the translation api stuff but before it's appended to the TweetBody with the translation.

I tried my best to copy the way everyone else did things but I've never taken a code class and don't work in the industry so please let me know if I need to go back and fix it. If this is wrong, breaks something, or causes lag. I'm cool with learning how to make it better!

Thank you for coming to my pull request.

@dimdenGD
Copy link
Owner

dimdenGD commented Oct 23, 2024

Only add new strings at the bottom of language file, you need to move new ones.

@dimdenGD dimdenGD merged commit a9fd92c into dimdenGD:master Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants