-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Svelte 5 runes, snippets, callbacks #214
Conversation
Co-authored-by: Daniel Imfeld <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 77 out of 92 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- package.json: Language not supported
- src/app.postcss: Language not supported
- src/lib/AttributionControl.svelte: Language not supported
- src/lib/CircleLayer.svelte: Language not supported
- src/lib/Control.svelte: Language not supported
- src/lib/ControlButton.svelte: Language not supported
- src/lib/ControlGroup.svelte: Language not supported
- src/lib/DeckGlLayer.svelte: Language not supported
- src/lib/DefaultMarker.svelte: Language not supported
- src/lib/FillExtrusionLayer.svelte: Language not supported
- .eslintrc.cjs: Evaluated as low risk
- postcss.config.js: Evaluated as low risk
- .changeset/nice-waves-bake.md: Evaluated as low risk
- .changeset/honest-shrimps-tie.md: Evaluated as low risk
- .changeset/ten-trees-shop.md: Evaluated as low risk
Comments skipped due to low confidence (1)
eslint.config.js:3
- The import statement for 'eslint-plugin-svelte' is incorrect. It should be 'eslint-plugin-svelte'.
import svelte from 'eslint-plugin-svelte';
Copilot review not too useful on Svelte yet, oh well |
This fixes one of the misunderstandings in the package, which was that map.loaded() works differently from Leaflet.
Useless comment to express my enthusiasm :) |
Breaking Changes
map
attribute added to them since this is already present astarget
Other Changes
Tasks
import.meta
use in tailwind config, but my local Node fails if I userequire.resolve
run
and convert to proper Svelte 5Closes #187
Closes #188