Add ISO 8601 Date Parsing #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this working for you? Tried applying your changes and its still not working with these dates. Any insight or changes maybe not in the PR would be appreciated. Thanks! |
|
Yeah it works for me, but I followed the scene rules. If you have actual ISO8601 dates (non-scene) then I suggest you fork and use Test Driven Development to come up with a better version for your requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds capability to detect any ISO 8601 dates in the title after the year. #14 as a result.
Added new tests which pass.
Modified the test script to test PTN relative to the repo (to stop a repeat of #21).