Support darwin-arm64

[awinecki]

Looks amazing – can't wait to test it out! Though it doesn't seem to work on m1 macs yet..

[dlvhdr]

Oh bummers.. I don't have an m1, what error are you getting?

[AlyxPractice]

Not much information unfortunately:

$ gh extension install dlvhdr/gh-prs
gh-prs unsupported for darwin-arm64. Open an issue: `gh issue create -R dlvhdr/gh-prs -t'Support darwin-arm64'`

But I think it's because there is no assets called darwin-arm64 in the releases assets, based on what I understand from https://github.com/cli/cli/blob/b5d90e120405ee5a7fe6dfdcc58f1eeffbb9f88c/pkg/cmd/extension/manager.go#L360-L364

And also from what I understand, the Github action used to release this project does not support anymore a list of custom platform to build for (cli/gh-extension-precompile@e482de8, related discussion: cli/gh-extension-precompile#2)

I've opened a PR on their project so it will build for darwin-arm64 platform: cli/gh-extension-precompile#3

[dlvhdr]

Thanks @VictorBersy that's a lot of good info you researched.. Yeah you understood correctly, I just use the github action, I don't know how to personally compile to different targets, so that was an easy solution for this.

[AlyxPractice]

Let's see if they accept my PR or not. Meanwhile, if you want to publish it ASAP for ARM Mac, you could try to use an older version of the Github Action:

- uses: cli/[email protected]
  with:
    platforms: "darwin-amd64,darwin-arm64,linux-386,linux-arm,linux-amd64,linux-arm64,windows-386,windows-amd64"

But that's not very future proof as the latest version won't be used.

[dlvhdr]

@awinecki I think it should be fixed now, thanks to @abdfnx, can you check?

[AlyxPractice]

Yes I was able to install it, thanks a lot!

[abdfnx]

Yes I was able to install it, thanks a lot!

good news

[joelazar]

@dlvhdr, could you provide a binary for linux-amd64 too?

[abdfnx]

@dlvhdr, could you provide a binary for linux-amd64 too?

you got it

[abdfnx]

@joelazar can you try it now ?

[joelazar]

working like a charm :) thanks for the quick fix!

[abdfnx]

working like a charm :) thanks for the quick fix!

anytime bro, and thanks @dlvhdr for building this great extension

[awinecki]

@dlvhdr confirming it works! ❤️ soo amazing! Sorry for not replying before. Anyway, can't wait to start using this CLI. Thank you!

[mislav]

Thanks everyone for your patience and for sharing temporary workarounds!

The latest GitHub CLI 2.8.0 release fixes this by falling back to amd64 binary if Rosetta is installed. If an arm64 binary is found, for example as a product of the latest gh-extension-precompile action, however, then its codesigning is fixed after downloading to allow execution by the OS.