Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darwin-arm64 platform #3

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Add darwin-arm64 platform #3

merged 1 commit into from
Apr 13, 2022

Conversation

AlyxPractice
Copy link
Contributor

Hello,

I was trying to install this extension https://github.com/dlvhdr/gh-prs and it's not built for darwin-arm64. I've investigated a bit and it led me to open this PR.

I'm not sure if this change is enough, as I'm not familiar with the go ecosystem. I'm available if you need me to test anything :)

Related issue: dlvhdr/gh-dash#10

@vilmibm
Copy link
Contributor

vilmibm commented Dec 2, 2021

Hi,

We're matching the platforms that gh itself ships for. I'll happily merge this once we're officially supporting darwin-arm64 over in gh itself. You can comment on or track that work in: cli/cli#2426

@thehedgefrog
Copy link

@vilmibm even though the linked issue is still open, gh supports Apple Silicon by way of Homebrew. Would like to see this merged!

@Imansame Imansame linked an issue Apr 13, 2022 that may be closed by this pull request
Closed
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will work well with gh v2.8.0+ 🙇

@mislav mislav merged commit 23c367c into cli:trunk Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ima!
4 participants