-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #5 from dolliejs/dev
add publish script and optimize ci workflow
- Loading branch information
Showing
12 changed files
with
18,855 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,29 @@ $ git clone [email protected]:dolliejs/dollie.git | |
$ cd dollie && npm i && lerna bootstrap | ||
``` | ||
|
||
## Flow Management | ||
|
||
### For Core Contributors | ||
|
||
#### New Feature | ||
|
||
1. Checkout a new branch from `master`, name it as `feat/<name>` | ||
2. Commit code to this branch | ||
3. Make a Pull Request that merge from your branch to `master` | ||
|
||
#### Hot Fixes | ||
|
||
1. Checkout a new branch from `master`, name it as `hotfix/<name>` | ||
2. Fix bugs and commit code to this branch | ||
3. Make a Pull Request to `master` | ||
4. Merge and tag a new version in `dollie@<number>.<number>.<number>` format | ||
|
||
### For Normal Contributors | ||
|
||
1. Fork this project to your namespace | ||
2. Commit code and push to your forked origin | ||
3. Make a Pull Request, merge from your repo to `master` branch of `dolliejs/dollie` | ||
|
||
## Start Developing | ||
|
||
We provide a lot of examples, you can run the examples: | ||
|
@@ -55,18 +78,24 @@ $ npm link | |
$ dollie init foo bar | ||
``` | ||
|
||
## Generate New Version & Publish | ||
## Generate New Version | ||
|
||
```bash | ||
# execute in your feature branch | ||
$ lerna version {major}.{minor}.{patch} --no-git-tag-version | ||
``` | ||
|
||
1. **Checkout to `master` branch** | ||
2. Run `lerna version {major}.{minor}.{patch}` | ||
Then commit the changes and push to remote origin. | ||
|
||
> Please note that the version must follow the following conventions: | ||
> The version is seperated by `major`, `minor` and `patch` parts: | ||
> 1. `major` means major updates, usually represents the API changes or some APIs are deleted | ||
> 2. `minor` means the new version add some new APIs or refactor the existed APIs | ||
> 3. `patch` means some bugs are fixed | ||
After Lerna pushing the new tags to remote origin, the CI workflow will start automatically to build and publish the new version to NPM. | ||
## Publish Packages | ||
|
||
> NOTE: Only core contributors can publish packages, by merging from other branch to `master` and add a tag in `dollie@<number>.<number>.<number>` format. After a commit on `master` is beeing tagged, the CI will build and publish all packages automatically. | ||
## Pull Request Guidelines | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,6 @@ temp | |
.version | ||
.versions | ||
.changelog | ||
package-lock.json | ||
.idea | ||
test.ts | ||
lib | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.