feat: angular 17 support #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - upgrade all dependency to support angular 17 - bump GitHub actions image from ubuntu-20.04 => ubuntu-22.04 - bump actions/checkout from v2 to v4 - bump actions/setup-node from v2 to v4 - use `.nvmrc` file to manage node.js version - removed `Workaround for JSDOM missing transform property`. Not needed anymore - use `buildTarget` instead of deprecated `browserTarget` in `angular.json` BREAKING CHANGE: The upgrade to Angular 17 breaks compatibility with Angular 16.
|
Hi @dominique-mueller , If you will have time please review this PR. Thank you, |
|
Hi @dominique-mueller , Can you check this this PR please? Thank you. |
|
@dominique-mueller any status on accepting this PR? |
|
i just add |
|
Didn't work for me, is the update still coming? |
|
I published a version that support angular 17 https://www.npmjs.com/package/@ert78gb/angular-notifier If you need. I haven't advertised it because I hope this repo will keep maintaining. I haven't upgraded my project to angular 18 so my version support only 17 currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
.nvmrcfile to manage node.js versionWorkaround for JSDOM missing transform property. Not needed anymorebuildTargetinstead of deprecatedbrowserTargetinangular.jsonBREAKING CHANGE: The upgrade to Angular 17 breaks compatibility with Angular 16.