Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs fix spelling issues #634

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nnsW3
Copy link

@nnsW3 nnsW3 commented Aug 21, 2024

Hello
I found several spelling issues in your docs.
Br, Elias.

@phil-opp
Copy link
Collaborator

Thanks for the PR!

The first two changes are just British English vs US English. I'm fine with changing them to the US spelling, but I don't have a strong opinion on this. What do you think @haixuanTao ?

@haixuanTao
Copy link
Collaborator

I think that we have mainly used British English, so I guess we should stay on British English?

@phil-opp
Copy link
Collaborator

I think that we have mainly used British English

I don't think that this is the case. For example, we use 'color' multiple times in this repo, but 'colour' only appears in some dependency name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants