Test queue size latest latency #652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st data instead of being the latest data. There might be a queue somewhere that is creating this descrepenc.y
haixuanTao
added a commit
that referenced
this pull request
Oct 13, 2024
In order to get the best performance from Qwenvl2, we need to temporary add this piece of code that is going to unqueue qwenvl queue. This is directly linked to: #652 which is that we currently having a queue issue within nodes for `queue_size: 1` where the queue is actually pending older data and not the newest one.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of error that I will probably need @phil-opp to help me on, which is that the dora queue_size keeps one old message in the queue and not drop all oldest input.
We need to revise our different queues of inputs and make sure to only store the latest input.
This happens in both rust and python, I have added one example of each.
To test