minimize requests to backend from frontend on event page DOT-262 #696
Conversation
prev behaviour: fetch event and attendance event from backend in useeffect with userLoggedIn as dep. This causes fetching being done two times, even though user logged in is not relevant.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
DOT-262 Prepare for Åre and Julebord attendance opening
Julebord is opening for attendance: 4th of november
|
|
Kudos, SonarCloud Quality Gate passed!
|
henrikskog
changed the title
The queries made to the backend from online.ntnu.no/events/{event} are expensive. To avoid that the backend crashes on big events, we want to be smart about how many requests we send from the frontend.
Measures
Double fetching bug
Prev behaviour: User goes to the event detail page. Event/attendance event data is fetched from backend. This is done in a useEffect with userLoggedIn as dep. This causes useEffect to be ran twice, as isLoggedIn goes from false on init to true.
Now: event data is fetched from the backend once independent of user being logged in or not. For the user, there is no difference as to before.
Caching backend response when fresh content is not needed