Created a custom awaiter that guarantees that we complete on a different threadpool thread. #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and System.Net.Http versions that have been flagged as containing known high severity vulnerabilities.
…ent threadpool thread. Previously, an awaited Task had a non-zero chance of completing before it was awaited, in which case execution would continue on the same thread.
leeoades
force-pushed
the
bugfix/really-guarantee-sync-context-lost
branch
from
e028625
to
4941336
Compare
|
Rebased onto #608 in order to remove the dodgy dependencies. |
crozone
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an awaited Task had a non-zero chance of completing before it was awaited, in which case execution would continue on the same thread. I created a unit test that repeatedly attempted to lose the context in order to detect race conditions which proved that other techniques (using Task) simply reduced the probability instead of guaranteeing success.