Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for CustomAttrbute #9175

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

MSDN-WhiteKnight
Copy link
Contributor

Add remarks and example for System.Reflection.Metadata.CustomAttrbute

@MSDN-WhiteKnight MSDN-WhiteKnight requested a review from a team as a code owner August 2, 2023 17:33
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 2, 2023
@learn-build-service-prod
Copy link

Learn Build status updates of commit d338d34:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/CustomAttributeSnippets.cs ✅Succeeded View
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/CustomAttributeSnippets.csproj ✅Succeeded
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/Program.cs ✅Succeeded
xml/System.Reflection.Metadata/CustomAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting to give @gewarren final review / merge decision.

I've read through the code and the text, and I think it's good to merge.

Co-authored-by: Genevieve Warren <[email protected]>
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@learn-build-service-prod
Copy link

Learn Build status updates of commit 7bdcaca:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/CustomAttributeSnippets.cs ✅Succeeded View
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/CustomAttributeSnippets.csproj ✅Succeeded
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/Program.cs ✅Succeeded
xml/System.Reflection.Metadata/CustomAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit feb6a87:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/CustomAttributeSnippets.cs ✅Succeeded View
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/CustomAttributeSnippets.csproj ✅Succeeded
snippets/csharp/System.Reflection.Metadata/CustomAttribute/Overview/Program.cs ✅Succeeded
xml/System.Reflection.Metadata/CustomAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 706cc50 into dotnet:main Aug 21, 2023
2 checks passed
@gewarren
Copy link
Contributor

Thanks @MSDN-WhiteKnight!

@MSDN-WhiteKnight MSDN-WhiteKnight deleted the custom-attribute branch August 23, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Reflection.Metadata community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants