Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into live #9190

Merged
merged 1 commit into from
Aug 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions xml/System.Runtime.CompilerServices/MethodImplOptions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@
</ReturnValue>
<MemberValue>256</MemberValue>
<Docs>
<summary>The method should be inlined if possible.</summary>
<summary>
<para>The method should be inlined if possible.</para>
<para>Unnecessary use of this attribute can reduce performance. The attribute might cause implementation limits to be encountered that will result in slower generated code. Always measure performance to ensure it's helpful to apply this attribute.</para>
</summary>
</Docs>
</Member>
<Member MemberName="AggressiveOptimization">
Expand Down Expand Up @@ -148,9 +151,8 @@
<MemberValue>512</MemberValue>
<Docs>
<summary>
<para>The method contains code that should always be optimized by the just-in-time (JIT) compiler.</para>
<para>Use this attribute if running an unoptimized version of the method has undesirable effects, for instance causing too much overhead or extra memory allocation.</para>
<para>Methods with this attribute may not have optimal code generation. They bypass the first tier of <a href="/dotnet/core/runtime-config/compilation#tiered-compilation">Tiered Compilation</a> and therefore can't benefit from optimizations that rely on tiering, for example, <a href="/dotnet/core/runtime-config/compilation#profile-guided-optimization">Dynamic PGO</a> or optimizations based on initialized classes.</para>
<para>The method contains code that should always be optimized for performance.</para>
<para>It's rarely appropriate to use this attribute. Methods that apply this attribute bypass the first tier of <a href="/dotnet/core/runtime-config/compilation#tiered-compilation">tiered compilation</a> and therefore don't benefit from optimizations that rely on tiered compilation. Those optimizations include <a href="/dotnet/core/runtime-config/compilation#profile-guided-optimization">dynamic PGO</a> and optimizations based on initialized classes. Use of this attribute might also increase memory use. Always measure performance to ensure it's helpful to apply this attribute.</para>
</summary>
</Docs>
</Member>
Expand Down