Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-pass porting of System.Text.Json API docs. #9195

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Aug 17, 2023

NB more passes will be necessary to account for RC1 APIs that haven't been ingested yet + any missing doc elements that will be filled out manually.

Contributes to dotnet/runtime#88577

@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

NB more passes will be necessary to account for RC1 APIs that haven't been ingested yet + any missing doc elements that will be filled out manually.

Contributes to #88577

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json

Milestone: -

@learn-build-service-prod

This comment was marked as outdated.

xml/System.Text.Json.Nodes/JsonArray.xml Outdated Show resolved Hide resolved
xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
xml/System.Text.Json/JsonSerializerOptions.xml Outdated Show resolved Hide resolved
xml/System.Text.Json/JsonSerializerOptions.xml Outdated Show resolved Hide resolved
xml/System.Text.Json/JsonSerializerOptions.xml Outdated Show resolved Hide resolved
xml/System.Text.Json/JsonSerializer.xml Outdated Show resolved Hide resolved
xml/System.Text.Json/JsonSerializer.xml Outdated Show resolved Hide resolved
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. @gewarren I'll apply them myself since @eiriktsarpalis is currently OOF.

xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
xml/System.Text.Json.Nodes/JsonNode.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
@learn-build-service-prod
Copy link

Learn Build status updates of commit 0ee79e7:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Nodes/JsonArray.xml ✅Succeeded View
xml/System.Text.Json.Nodes/JsonNode.xml ✅Succeeded View
xml/System.Text.Json.Serialization.Metadata/JsonMetadataServices.xml ✅Succeeded View
xml/System.Text.Json.Serialization.Metadata/JsonPropertyInfo.xml ✅Succeeded View
xml/System.Text.Json.Serialization.Metadata/JsonTypeInfo.xml ✅Succeeded View
xml/System.Text.Json.Serialization.Metadata/JsonTypeInfoResolver.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonConverter.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonKnownNamingPolicy.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonNumberEnumConverter`1.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonObjectCreationHandling.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonObjectCreationHandlingAttribute.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonSourceGenerationOptionsAttribute.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonStringEnumConverter`1.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonUnmappedMemberHandling.xml ✅Succeeded View
xml/System.Text.Json.Serialization/JsonUnmappedMemberHandlingAttribute.xml ✅Succeeded View
xml/System.Text.Json/JsonEncodedText.xml ✅Succeeded View
xml/System.Text.Json/JsonNamingPolicy.xml ✅Succeeded View
xml/System.Text.Json/JsonSerializer.xml ✅Succeeded View
xml/System.Text.Json/JsonSerializerOptions.xml ✅Succeeded View
xml/System.Text.Json/Utf8JsonWriter.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop merged commit a8c1e01 into dotnet:main Aug 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants