-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the Dispose information to the Activity remarks #9227
Conversation
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Tagging subscribers to this area: @tommcdon Issue DetailsSummaryThis paragraph is a bit confusing. It sounds like we need to call
|
Learn Build status updates of commit 775d118: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Genevieve Warren <[email protected]>
Thank you for the feedback @gewarren |
Thanks for adding this note @askpt. |
Learn Build status updates of commit e5ef333: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Summary
This paragraph is a bit confusing. It sounds like we need to call
Activity.Stop()
all the time, but this document (https://learn.microsoft.com/en-us/dotnet/core/diagnostics/distributed-tracing-instrumentation-walkthroughs#notes) points out that onDispose
it will also stop the Activity leading to a cleaner code.