Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Dispose information to the Activity remarks #9227

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

askpt
Copy link
Contributor

@askpt askpt commented Aug 29, 2023

Summary

This paragraph is a bit confusing. It sounds like we need to call Activity.Stop() all the time, but this document (https://learn.microsoft.com/en-us/dotnet/core/diagnostics/distributed-tracing-instrumentation-walkthroughs#notes) points out that on Dispose it will also stop the Activity leading to a cleaner code.

@askpt askpt requested a review from a team as a code owner August 29, 2023 11:07
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 29, 2023
@ghost
Copy link

ghost commented Aug 29, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

This paragraph is a bit confusing. It sounds like we need to call Activity.Stop() all the time, but this document (https://learn.microsoft.com/en-us/dotnet/core/diagnostics/distributed-tracing-instrumentation-walkthroughs#notes) points out that on Dispose it will also stop the Activity leading to a cleaner code.

Author: askpt
Assignees: -
Labels:

area-System.Diagnostics, community-contribution

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit 775d118:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics/Activity.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

xml/System.Diagnostics/Activity.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
@askpt
Copy link
Contributor Author

askpt commented Aug 29, 2023

Thank you for the feedback @gewarren

@gewarren gewarren enabled auto-merge (squash) August 29, 2023 17:59
@gewarren
Copy link
Contributor

Thanks for adding this note @askpt.

@learn-build-service-prod
Copy link

Learn Build status updates of commit e5ef333:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics/Activity.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 695b963 into dotnet:main Aug 29, 2023
2 checks passed
@askpt askpt deleted the askpt/add_remark_activity branch August 29, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Diagnostics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants