Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize docs for new System.Net.Primitives API-s #9236

Merged
merged 11 commits into from
Sep 11, 2023

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Aug 30, 2023

Summary

Port/add all remaining doc changes for System.Net.Primitives finishing the work started in #9169. I added most <inheritdoc/> bits manually, since PortToDocs didn't really work well here.

Contributes to dotnet/runtime#88569.

/cc @gewarren @carlossanlop

@ghost
Copy link

ghost commented Aug 30, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Port all remaining doc changes for System.Net.Primitives. In cases where <inheritdoc/> is used, I reverted some changes added in #9169. If <inheritdoc/> works the way I think it should work, this should actually remove redundant information. I added most <inheritdoc/> bits manually, since PortToDocs didn't really work well here.

Contributes to dotnet/runtime#88569.

/cc @gewarren @carlossanlop

Author: antonfirsov
Assignees: antonfirsov
Labels:

area-System.Net

Milestone: -

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@antonfirsov antonfirsov marked this pull request as draft August 31, 2023 14:26
@antonfirsov
Copy link
Member Author

antonfirsov commented Aug 31, 2023

Converted to a draft, since <inheritdoc /> doesn't work the way I expected.

@learn-build-service-prod

This comment was marked as outdated.

@antonfirsov antonfirsov changed the title Port doc comments for System.Net.Primitives Finalize docs for new System.Net.Primitives API-s Sep 5, 2023
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 1b813ab:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/SocketException.xml ✅Succeeded View
xml/System.Net/IPAddress.xml ✅Succeeded View
xml/System.Net/IPNetwork.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@antonfirsov antonfirsov marked this pull request as ready for review September 5, 2023 20:37
@antonfirsov
Copy link
Member Author

@gewarren this is ready for review now.

xml/System.Net/IPAddress.xml Outdated Show resolved Hide resolved
xml/System.Net/IPAddress.xml Show resolved Hide resolved
xml/System.Net/IPAddress.xml Outdated Show resolved Hide resolved
xml/System.Net/IPAddress.xml Outdated Show resolved Hide resolved
xml/System.Net/IPAddress.xml Show resolved Hide resolved
xml/System.Net/IPNetwork.xml Outdated Show resolved Hide resolved
xml/System.Net/IPNetwork.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
@learn-build-service-prod
Copy link

Learn Build status updates of commit 5a2374d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/SocketException.xml ✅Succeeded View
xml/System.Net/IPAddress.xml ✅Succeeded View
xml/System.Net/IPNetwork.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 27735b8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/SocketException.xml ✅Succeeded View
xml/System.Net/IPAddress.xml ✅Succeeded View
xml/System.Net/IPNetwork.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit b0a5555:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/SocketException.xml ✅Succeeded View
xml/System.Net/IPAddress.xml ✅Succeeded View
xml/System.Net/IPNetwork.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop merged commit 3bd85b5 into main Sep 11, 2023
2 checks passed
@carlossanlop carlossanlop deleted the antonfirsov/update-System.Net.Primitives-01 branch September 11, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants