-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Bulk copy of byrefs #101761
JIT: Bulk copy of byrefs #101761
Conversation
@jkotas PTAL |
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunConstants.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@jakobbotsch cc @dotnet/jit-contrib PTAL jit part, |
src/coreclr/jit/lower.cpp
Outdated
if (data->OperIs(GT_IND)) | ||
{ | ||
// Drop GT_IND nodes | ||
BlockRange().Remove(data); | ||
data = data->AsIndir()->Addr(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to worry about any indir flags here, like GTF_IND_VOLATILE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I think it's safer to just give up on those here, fixed.
Closes #101699
Closes #8627
Use a bulk copy when we need to copy a struct with gc fields (non-null) instead of individual gc write barriers