-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instrumentation (mostly) for DATAS #107853
Conversation
…ith gen0 min size debugging
Tagging subscribers to this area: @dotnet/gc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10882418393 |
Filled a known issue for the numerics failures. dotnet/dnceng#4082 |
66ae9b5
to
d8aa9f8
Compare
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10891400472 |
@Maoni0 backporting to release/9.0 failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: added instru to help with DATAS debugging + record LLC size to help with gen0 min size debugging
.git/rebase-apply/patch:349: trailing whitespace.
hc_record_inactive_waiting = 7,
.git/rebase-apply/patch:456: trailing whitespace.
// bgc_thread_running was false but bgc_thread was true.
.git/rebase-apply/patch:475: trailing whitespace.
// though it was not in progress when we check before calling it.
warning: 3 lines add whitespace errors.
Using index info to reconstruct a base tree...
M src/coreclr/gc/gc.cpp
M src/coreclr/gc/gcpriv.h
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/gc/gcpriv.h
CONFLICT (content): Merge conflict in src/coreclr/gc/gcpriv.h
Auto-merging src/coreclr/gc/gc.cpp
CONFLICT (content): Merge conflict in src/coreclr/gc/gc.cpp
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 added instru to help with DATAS debugging + record LLC size to help with gen0 min size debugging
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@Maoni0 an error occurred while backporting to release/9.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
/ba-g known issue dotnet/dnceng#3879 |
merging since that linux-x64 debug lib job isn't making any progress due to the dnceng issue. thanks for all the reviews!! |
add instru to help with DATAS debugging + record heap count change history on blocking GC threads and BGC threads (I'm including a change to get the m_OSThreadId field of the Thread object since we recently discovered an issue where GC indicates a BGC thread was successfully created yet that field is 0. I'm only recording this on the OS we discovered this on. for future releases we should get it properly via a GCToEEInterface method) + record BGC thread creation history record LLC size to help with gen0 min size debugging
add instru to help with DATAS debugging + record heap count change history on blocking GC threads and BGC threads (I'm including a change to get the m_OSThreadId field of the Thread object since we recently discovered an issue where GC indicates a BGC thread was successfully created yet that field is 0. I'm only recording this on the OS we discovered this on. for future releases we should get it properly via a GCToEEInterface method) + record BGC thread creation history record LLC size to help with gen0 min size debugging
add instru to help with DATAS debugging
m_OSThreadId
field of theThread
object since we recently discovered an issue where GC indicates a BGC thread was successfully created yet that field is 0. I'm only recording this on the OS we discovered this on. for future releases we should get it properly via aGCToEEInterface
method)record LLC size to help with gen0 min size debugging