Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0-staging] JIT: Read back all replacements before statements with implicit EH control flow #109143

Open
wants to merge 3 commits into
base: release/9.0-staging
Choose a base branch
from
Open

[release/9.0-staging] JIT: Read back all replacements before statements with implicit EH control flow #109143

wants to merge 3 commits into from
+126 −24

Commits on Oct 23, 2024

  1. Add a test

    @jakobbotsch
    jakobbotsch authored and github-actions committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0ef3ab7 View commit details
    Browse the repository at this point in the history

  2. JIT: Read back all replacements before statements with implicit EH co… 

    …ntrol flow

Physical promotion sometimes needs to insert read backs of all stale
pending replacements when it encounters potential implicit EH control
flow (that is, intra-function control flow because of locally caught
exceptions). It would be possible for this to interact with QMARKs such
that we inserted readbacks inside one of the branches, yet believed we
had read back the replacement on all paths.

The fix here is to indiscriminately start reading back all replacements
before a statement that may cause potential intra-function control flow
to occur.

Fix #108969
    @jakobbotsch
    jakobbotsch authored and github-actions committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    60ca01b View commit details
    Browse the repository at this point in the history

  3. Remove space

    @jakobbotsch
    jakobbotsch authored and github-actions committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7289665 View commit details
    Browse the repository at this point in the history