-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NamedPipeClientStream Connect with SafePipeHandle #110075
Conversation
* Check that isConnected in the NamedPipeClientStream constructor is always true. * Added an argument test. Fixes dotnet#32760
* Created a new constructor without the argument. * Marked the old constructor as obsolete. Fixes dotnet#32760
Note regarding the
|
1 similar comment
Note regarding the
|
[Obsolete] | ||
public NamedPipeClientStream(PipeDirection direction, bool isAsync, bool isConnected, SafePipeHandle safePipeHandle) | ||
: this(direction, isAsync, safePipeHandle) | ||
{ | ||
if (!isConnected) | ||
{ | ||
throw new ArgumentOutOfRangeException(nameof(isConnected)); | ||
} | ||
} | ||
|
||
// Create a NamedPipeClientStream from an existing server pipe handle. | ||
public NamedPipeClientStream(PipeDirection direction, bool isAsync, SafePipeHandle safePipeHandle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need API review, which isn't present in linked issue.
Thanks for trying to help out! New surface area needs to first be reviewed and approved, following: |
@stephentoub I'm sorry for the inconvenience. I created a new PR (#110175) without the changes to the public API. |
No worries. Thanks! |
I am aware that I did slightly more than in the original issue. Therefore I created a base commit and two additional commits that can be easily removed from this PR if desired.
Fixes #32760