Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix System.Reflection.Emit SetChecksum creating invalid pdb #110097

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix System.Reflection.Emit SetChecksum creating invalid pdb #110097

merged 2 commits into from
Nov 26, 2024

Conversation

tgjones
Copy link
Contributor

@tgjones tgjones commented Nov 22, 2024

Fixes #110096.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 22, 2024
@tgjones tgjones changed the title Fix document SetChecksum creating invalid pdb Fix System.Reflection.Emit SetChecksum creating invalid pdb Nov 22, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 23, 2024
Open
@tgjones
Copy link
Contributor Author

tgjones commented Nov 23, 2024

The CI failures look like instabilities to me - I can't see anything that could be related to my changes amongst the failures.

@steveharter steveharter self-requested a review November 25, 2024 14:37
steveharter
steveharter approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@steveharter steveharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for researching and fixing this.

Do you need this backported to v9?

@tgjones
Copy link
Contributor Author

tgjones commented Nov 25, 2024

Thanks for approving the PR.

I do need it backported to v9. I don’t know the process for that. Should I make a PR targeting the v9 branch, or is there something automated for that, or…?

@steveharter
Copy link
Member

Test failures likely due to #110127

@steveharter
Copy link
Member

I do need it backported to v9. I don’t know the process for that. Should I make a PR targeting the v9 branch, or is there something automated for that, or…?

I'll take care of it once this PR is in.

@steveharter steveharter added this to the 10.0.0 milestone Nov 25, 2024
@steveharter steveharter self-assigned this Nov 25, 2024
@steveharter steveharter mentioned this pull request Nov 26, 2024
Open
3 tasks
@steveharter steveharter merged commit ead4d81 into dotnet:main Nov 26, 2024
83 checks passed
@steveharter
Copy link
Member

/backport to release/9.0-staging

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12040136075

@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveharter steveharter steveharter approved these changes

Assignees

@steveharter steveharter

Labels
area-System.Reflection.Emit bug community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

System.Reflection.Emit SetChecksum produces invalid pdb
2 participants
@tgjones @steveharter