Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing System.Buffers documentation #90891

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Aug 21, 2023

This covers the APIs that were missing docs from #88564

The corresponding docs PR is dotnet/dotnet-api-docs#9206

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 21, 2023
@ghost ghost assigned tannergooding Aug 21, 2023
@tannergooding tannergooding marked this pull request as ready for review August 21, 2023 20:34
@tannergooding
Copy link
Member Author

@carlossanlop, could I get a sign-of on this? Identical to what went into the docs side.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please make sure to also bring in the feedback provided by Genevieve in the dotnet-api-docs PR.

@tannergooding tannergooding merged commit 7bf30e7 into dotnet:main Aug 24, 2023
161 of 167 checks passed
@tannergooding tannergooding deleted the fix-88564 branch August 24, 2023 18:50
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants