Improvements and Bug Fixes for gae-sessions v1.07 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(efficiency)Session id length cut in more than half (efficiency)timestamp in SID has been reduced form 10 bytes to 4 bytes with bit packing (efficiency)add a cron job to the demos to delete stale cookies (efficiency)Hash functions used to generate session id cut from 3 to just 1 (Security)SIDs contain more entropy (Security)removed use of md5() (bug)SID_LEN can now be changed without causing offset exceptions (bug)delete_expired_sessions function was not checking remaining cookies properly
|
This pull request introduces bugs to the latest's version. It doesn't really fix anything besides returning if there are more sessions to be deleted (not a bug - it is well explained in the code). The unpacking of the SID's timestamp is broken, because it's being encoded as base64 when generated and the decoding doesn't happen when the cookie is read; decoding wouldn't work either, because the base64 string is greater than of the SID's length (32). Just check the cookie on your browser to see if it reflects the expiration you defined; it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(efficiency)Session id length cut in more than half
(efficiency)timestamp in SID has been reduced form 10 bytes to 4 bytes with bit packing
(efficiency)add a cron job to the demos to delete stale cookies
(efficiency)Hash functions used to generate session id cut from 3 to just 1