Fix install.sh to run prerequisite checks on all distros #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1346
As far as I can tell, the existing logic means that prerequisite checks would only run on ChimeraOS, which doesn't seem like the desired behavior (the "not SteamOS" logic short-circuits everything else away and just prints "installing EmuDeck").
So the logic after this should be "everything except for SteamOS installs prereqs, including ChimeraOS". Let me know if that's not correct.
Could be totally wrong on this, but the prereq checks didn't run for me on Arch before this change and now run after! Happy to adjust if needed.