Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Dockerfile #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

r4jeshwar
Copy link

I'm happy to dockerize the Timevault and attached the Dockerfile in this PR.

@CluEleSsUK
Copy link
Contributor

Many thanks for your contribution!

Due to .parcel-cache being platform-dependent, this fails on apple silicon if you've already run some local builds.
Could you possibly change the COPY . . to COPY the package*.json and src files specifically?

@r4jeshwar
Copy link
Author

Many thanks for your contribution!

Due to .parcel-cache being platform-dependent, this fails on apple silicon if you've already run some local builds. Could you possibly change the COPY . . to COPY the package*.json and src files specifically?

I have done the changes which you mentioned above. I approve of the changes that went into this PR.

WORKDIR /app

COPY package*.json ./

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN apk add --update --no-cache python3 build-base gcc && ln -sf /usr/bin/python3 /usr/bin/python

I had to add this to get node-gyp building correctly. After that it worked perfectly though, so should be ready to rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants