-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat - Allowing raw_input and timestamp flags #73
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your first contribution!
I definitely agree with the change in spirit and the PR looks pretty close, but could you address the following:
- add a few unit tests around the flag combos to make sure they work
- add a few e2e tests for the CLI in
tlock_test.go
- run
golangci-lint run --fix
over everything (you may have already done this!)
The current CLI supports stdin input:
works on my machine and gives me:
which correctly decrypts too:
|
Signed-off-by: 1griffy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready!
Co-authored-by: Yolan Romailler <[email protected]>
Co-authored-by: Yolan Romailler <[email protected]>
Following up on this one - if you need this I can resolve the conflicts |
sorry this slipped through the net - if you could resolve the conflicts we'll get it merged asap! |
As of now the cli only accepts file input
However for usablility sake, users should also be allowed to pass simple command line input
A useful feature could be if users can timestamp as input i.e. allow decrypt only after new year 2024
This PR aims to add that