-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent delete drawing when input focus #3629
base: dev
Are you sure you want to change the base?
Conversation
View Deployment
|
Playwright test resultsDetails 11 tests across 5 suites Failed testschromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content Flaky testschromium › memory/memory.spec.ts › memory |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3629 +/- ##
==========================================
- Coverage 31.81% 31.80% -0.01%
==========================================
Files 2194 2225 +31
Lines 115544 115624 +80
Branches 25448 25450 +2
==========================================
+ Hits 36759 36776 +17
- Misses 78785 78848 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
548e11b
to
ccd9177
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution is not suitable for all situations. Let's suppose that if you have other input elements in DrawingTransform.ts
or elsewhere, you have to edit these components one by one. There should be a generic solution to this problem.
close #2628
Pull Request Checklist