Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent delete drawing when input focus #3629

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

siam-ese
Copy link
Contributor

close #2628

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 29, 2024
@siam-ese siam-ese added bug:should be fixed qa:untested This PR is ready to be tested and removed qa:untested This PR is ready to be tested bug:should be fixed labels Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 29, 2024

Playwright test results

failed  2 failed
passed  8 passed
flaky  1 flaky

Details

stats  11 tests across 5 suites
duration  4 minutes, 23 seconds
commit  4aa048b
info  For more information, see full report

Failed tests

chromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content
chromium › visual-comparison/sheet/sheets-visual-comparison.spec.ts › diff demo sheet content

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 31.80%. Comparing base (72e43d6) to head (989c932).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
...rawing-ui/src/controllers/drawing-ui.controller.ts 0.00% 15 Missing ⚠️
...ing-ui/src/controllers/sheet-drawing.controller.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3629      +/-   ##
==========================================
- Coverage   31.81%   31.80%   -0.01%     
==========================================
  Files        2194     2225      +31     
  Lines      115544   115624      +80     
  Branches    25448    25450       +2     
==========================================
+ Hits        36759    36776      +17     
- Misses      78785    78848      +63     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 29, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 29, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is not suitable for all situations. Let's suppose that if you have other input elements in DrawingTransform.ts or elsewhere, you have to edit these components one by one. There should be a generic solution to this problem.

@siam-ese siam-ese requested a review from wzhudev October 8, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants