Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): some formulas need to be tested in dev #4116

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Nov 21, 2024

test in https://univer-preview.vercel.app/sheets/

  • ROUNDBANK
  • ISBETWEEN
  • AVERAGE.WEIGHTED
  • MARGINOFERROR
  • ISEMAIL
  • ISURL
  • ENCODEURL
  • EPOCHTODATE
  • TO_DATE
  • ISDATE
  • LINEST
  • LOGEST
  • TREND
  • ARRAY_CONSTRAIN
  • FLATTEN
  • IMCOTH
  • IMLOG
  • IMTANH

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

failed  1 failed
passed  19 passed

Details

stats  20 tests across 9 suites
duration  5 minutes, 46 seconds
commit  3b3bd47
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.79%. Comparing base (0dc0027) to head (3b3bd47).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4116   +/-   ##
=======================================
  Coverage   33.79%   33.79%           
=======================================
  Files        2457     2457           
  Lines      127593   127593           
  Branches    28562    28562           
=======================================
  Hits        43126    43126           
  Misses      84467    84467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

ROUNDBANK函数
单元格内输入=ROUNDBANK(523,10000),计算结果错误
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

ROUNDBANK function
Enter =ROUNDBANK(523,10000) in the cell, and the calculation result is wrong.
image

@jikkai jikkai marked this pull request as draft November 27, 2024 06:19
@jikkai
Copy link
Member

jikkai commented Nov 27, 2024

Mark as draft

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

ISBETWEEN函数

1、单元格内输入=ISBETWEEN(0,"AA",1,1,FALSE),错误码不对
企业微信截图_17326893133267

2、单元格内输入=ISBETWEEN(0,"AA","BB",1,FALSE),计算不出结果
image

3、单元格内输入=ISBETWEEN(0,1,FALSE),计算不出结果
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

ISBETWEEN function

  1. Enter =ISBETWEEN(0,"AA",1,1,FALSE) in the cell, the error code is incorrect
    Enterprise WeChat screenshot_17326893133267

  2. Enter =ISBETWEEN(0,"AA","BB",1,FALSE) in the cell, but the result cannot be calculated.
    image

  3. Enter =ISBETWEEN(0,1,FALSE) in the cell, but the result cannot be calculated.
    image

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

AVERAGE.WEIGHTED函数

1、单元格内输入=AVERAGE.WEIGHTED(A1:A2, B1:B2, C1, C2),计算不出结果
image

2、单元格内输入=AVERAGE.WEIGHTED(90,0),错误码不对
image

3、单元格内输入=AVERAGE.WEIGHTED(A1,B1),单元格为空,错误码不对
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

AVERAGE.WEIGHTED function

  1. Enter =AVERAGE.WEIGHTED(A1:A2, B1:B2, C1, C2) in the cell, but the result cannot be calculated.
    image

  2. Enter =AVERAGE.WEIGHTED(90,0) in the cell, the error code is incorrect
    image

  3. Enter =AVERAGE.WEIGHTED(A1,B1) in the cell. The cell is empty and the error code is incorrect.
    image

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

MARGINOFERROR函数

1、单元格内输入=MARGINOFERROR(A1:A2,B1),计算结果不对
image

2、单元格内输入=MARGINOFERROR(A1:A2,B1),计算结果未报错
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

MARGINOFERROR function

  1. Enter =MARGINOFERROR(A1:A2,B1) in the cell, and the calculation result is incorrect.
    image

  2. Enter =MARGINOFERROR(A1:A2,B1) in the cell, and no error will be reported in the calculation result.
    image

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

ENCODEURL函数
单元格内输入=ENCODEURL(A1:A2),A1=1,A2=2 计算结果不对
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

ENCODEURL function
Enter =ENCODEURL(A1:A2) in the cell, A1=1, A2=2. The calculation result is incorrect.
image

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

EPOCHTODATE函数

1、单元格内输入=EPOCHTODATE(1656356678000410,1),计算结果不对
image

2、单元格内输入=EPOCHTODATE(A2,2),格式不一致
样张:https://dev.univer.plus/sheet/?unit=3jvGWvZMRvqBNH8tS-ev1Q&type=2&subunit=8O9Q3N4j_m8KqEUfAeo-p
企业微信截图_17326969714489

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

EPOCHTODATE function

  1. Enter =EPOCHTODATE(1656356678000410,1) in the cell, and the calculation result is incorrect.
    image

  2. Enter =EPOCHTODATE(A2,2) in the cell, the format is inconsistent
    Sample: https://dev.univer.plus/sheet/?unit=3jvGWvZMRvqBNH8tS-ev1Q&type=2&subunit=8O9Q3N4j_m8KqEUfAeo-p
    Enterprise WeChat screenshot_17326969714489

@oumomomo
Copy link

TO_DATE函数
单元格内输入=TO_DATE(A1),按照图片内单元格的内容下拉填充,计算结果均不对
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

TO_DATE function
Enter =TO_DATE(A1) in the cell and fill it in according to the content of the cell in the picture. The calculation results are all wrong.
image

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

LINEST function
The calculation result is wrong
Sample: https://dev.univer.plus/sheet/?unit=9s3w2aVWQgeD08MpYM0paw&type=2&subunit=8La2fPi3UBAG6UxMGyVY9
image

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

LINEST函数

1、单元格内输入=LINEST(2,2,20,FALSE)。计算不出结果
image

2、单元格内输入=LINEST(A2:B2,C2:D2,TRUE,TRUE)/=LINEST(A2:B2,B2:C2,TRUE,TRUE),部分计算结果不对
样张:https://dev.univer.plus/sheet/?unit=zqLgWy0TRX6zWQAaiUULYQ&type=2&subunit=0NgSLXV8UhOirS-ee14S0
image
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

LINEST function

  1. Enter =LINEST(2,2,20,FALSE) in the cell. Can't calculate the result
    image

  2. Enter =LINEST(A2:B2,C2:D2,TRUE,TRUE)/=LINEST(A2:B2,B2:C2,TRUE,TRUE) in the cell, and some calculation results are incorrect.
    Sample: https://dev.univer.plus/sheet/?unit=zqLgWy0TRX6zWQAaiUULYQ&type=2&subunit=0NgSLXV8UhOirS-ee14S0
    image
    image

@oumomomo
Copy link

oumomomo commented Nov 27, 2024

LOGEST函数

1、单元格内输入=LOGEST(1,33100,TRUE,FALSE),计算不出结果
image

2、单元格内输入=LOGEST(B2:B7,A2:A7,TRUE,FALSE),B2为0时错误码不一致
样张:https://dev.univer.plus/sheet/?unit=Zp68028AQFiTpUaZNndylg&type=2&subunit=8O9Q3N4j_m8KqEUfAeo-p
image

3、单元格内输入=LOGEST(B2:B7,A2:A7,TRUE,FALSE),A1:A7为0时计算不出结果
样张:https://dev.univer.plus/sheet/?unit=bA5PGm4AQPGNvph29J-6RQ&type=2&subunit=8La2fPi3UBAG6UxMGyVY9
image

@univer-bot
Copy link

univer-bot bot commented Nov 27, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

LOGEST function

  1. Enter =LOGEST(1,33100,TRUE,FALSE) in the cell, but the result cannot be calculated.
    image

  2. Enter =LOGEST(B2:B7,A2:A7,TRUE,FALSE) in the cell. When B2 is 0, the error code is inconsistent.
    Sample: https://dev.univer.plus/sheet/?unit=Zp68028AQFiTpUaZNndylg&type=2&subunit=8O9Q3N4j_m8KqEUfAeo-p
    image

  3. Enter =LOGEST(B2:B7,A2:A7,TRUE,FALSE) in the cell. When A1:A7 is 0, the result cannot be calculated.
    Sample: https://dev.univer.plus/sheet/?unit=bA5PGm4AQPGNvph29J-6RQ&type=2&subunit=8La2fPi3UBAG6UxMGyVY9
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants