Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection should stop response after a popup shown #4156

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Nov 26, 2024

close https://github.com/dream-num/univer-pro/issues/3392

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku marked this pull request as ready for review November 26, 2024 08:42
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 26, 2024
Copy link

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 48 seconds
commit  09e4a25
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 33.72%. Comparing base (d1d4bbe) to head (09e4a25).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/scene.input-manager.ts 0.00% 7 Missing ⚠️
packages/engine-render/src/base-object.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/shape/scroll-bar.ts 0.00% 2 Missing ⚠️
...services/selection/doc-selection-render.service.ts 0.00% 1 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 1 Missing ⚠️
...ers/render-controllers/scroll.render-controller.ts 0.00% 1 Missing ⚠️
...src/services/selection/selection-render.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4156      +/-   ##
==========================================
- Coverage   33.73%   33.72%   -0.01%     
==========================================
  Files        2457     2457              
  Lines      127891   127907      +16     
  Branches    28638    28641       +3     
==========================================
  Hits        43141    43141              
- Misses      84750    84766      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants