feat: ff support for gray icon

drodil · Oct 3, 2024 · c768126 · c768126
1 parent 7f1c00c
commit c768126
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 18 deletions.
diff --git a/firefox/images/icon_disabled_1024.png b/firefox/images/icon_disabled_1024.png
diff --git a/firefox/images/icon_disabled_128.png b/firefox/images/icon_disabled_128.png
diff --git a/firefox/images/icon_disabled_16.png b/firefox/images/icon_disabled_16.png
diff --git a/firefox/images/icon_disabled_32.png b/firefox/images/icon_disabled_32.png
diff --git a/firefox/images/icon_disabled_64.png b/firefox/images/icon_disabled_64.png
diff --git a/firefox/yt.js b/firefox/yt.js
@@ -60,7 +60,7 @@ function debugLog(message) {
 }
 
 function isEnabledForTab(tab) {
-  if (!tab || !tab.url) {
+  if (!tab || !tab.url || options.disabled) {
     return false;
   }
 
@@ -148,6 +148,28 @@ function toggle_mute(tab) {
   sendMessage(tab, { action: "toggle_mute" });
 }
 
+function changeIcon(disabled) {
+  if (disabled) {
+    browser.action.setIcon({
+      path: {
+        16: "/images/icon_disabled_16.png",
+        32: "/images/icon_disabled_32.png",
+        64: "/images/icon_disabled_64.png",
+        128: "/images/icon_disabled_128.png",
+      },
+    });
+  } else {
+    browser.action.setIcon({
+      path: {
+        16: "/images/icon_16.png",
+        32: "/images/icon_32.png",
+        64: "/images/icon_64.png",
+        128: "/images/icon_128.png",
+      },
+    });
+  }
+}
+
 // Listen options changes
 browser.storage.onChanged.addListener(async function (changes) {
   enabledTabs = [];
@@ -158,30 +180,20 @@ browser.storage.onChanged.addListener(async function (changes) {
     options[key] = changes[key].newValue;
   }
 
-  if ("disabled" in changes) {
-    const tabs = await browser.tabs.query({ active: true });
-    if (!options.disabled) {
-      debugLog(`Extension enabled, resuming active tabs`);
-    } else {
-      debugLog(`Extension disabled, stopping active tabs`);
-    }
+  const tabs = await browser.tabs.query({ active: true });
 
-    for (let i = 0; i < tabs.length; i++) {
-      if (!options.disabled) {
-        resume(tabs[i]);
-      } else {
-        stop(tabs[i]);
-      }
+  for (let i = 0; i < tabs.length; i++) {
+    if (isEnabledForTab(tabs[i])) {
+      changeIcon(false);
+      resume(tabs[i]);
+    } else {
+      changeIcon(true);
     }
   }
 });
 
 // Tab change listener
 browser.tabs.onActivated.addListener(function (info) {
-  if (previous_window !== info.windowId) {
-    return;
-  }
-
   browser.tabs.get(info.tabId, async function (tab) {
     if (!isEnabledForTab(tab) || previous_tab === info.tabId) {
       return;