Skip to content

Commit

Permalink
Fix to SqlDatabaseRole (#1458)
Browse files Browse the repository at this point in the history
- Update unit test to have the correct description on the `Describe`-block
  for the test of `Set-TargetResource`.
  • Loading branch information
johlju authored Jan 2, 2020
1 parent abea9e8 commit 30f5e14
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)

- SqlServerDsc
- Added continuous delivery with a new CI pipeline.
- Update build.ps1 from latest template.

### Changed

Expand All @@ -28,6 +29,9 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
- The integration test has been temporarily disabled because when
the cluster feature is installed it requires a reboot on the
Windows Server 2019 build worker.
- SqlDatabaseRole
- Update unit test to have the correct description on the `Describe`-block
for the test of `Set-TargetResource`.

### Fixed

Expand Down
20 changes: 16 additions & 4 deletions build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,34 @@ param
[Parameter()]
$RequiredModulesDirectory = $(Join-Path 'output' 'RequiredModules'),

# Filter which tags to run when invoking Pester tests
# This is used in the Invoke-Pester.pester.build.ps1 tasks
[Parameter()]
[string[]]
$PesterTag,
$PesterScript,

# Filter which tags to run when invoking Pester tests
# This is used in the Invoke-Pester.pester.build.ps1 tasks
[Parameter()]
[string[]]
$PesterScript,
$PesterTag,

# Filter which tags to exclude when invoking Pester tests
# This is used in the Invoke-Pester.pester.build.ps1 tasks
[Parameter()]
[string[]]
$PesterExcludeTag,

# Filter which tags to run when invoking DSC Resource tests
# This is used in the DscResource.Test.build.ps1 tasks
[Parameter()]
[string[]]
$DscTestTag,

# Filter which tags to exclude when invoking DSC Resource tests
# This is used in the DscResource.Test.build.ps1 tasks
[Parameter()]
[string[]]
$DscTestExcludeTag,

[Parameter()]
[Alias('bootstrap')]
[switch]$ResolveDependency,
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/MSFT_SqlDatabaseRole.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ try
Assert-VerifiableMock
}

Describe "MSFT_SqlServerRole\Set-TargetResource" -Tag 'Set' {
Describe "MSFT_SqlDatabaseRole\Set-TargetResource" -Tag 'Set' {
BeforeEach {
Mock -CommandName Connect-SQL -MockWith $mockConnectSQL -Verifiable
Mock -CommandName New-Object -MockWith $mockNewObjectDatabaseRole -ParameterFilter {
Expand Down

0 comments on commit 30f5e14

Please sign in to comment.