installer(windows terminal): quote path

Without quoting the path, the door is open for executing unintended executables. This fixes git-for-windows/git#5100. Signed-off-by: Johannes Schindelin <[email protected]>
dscho · Aug 12, 2024 · 6d0b090 · 6d0b090
1 parent 0cacd22
commit 6d0b090
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/installer/install.iss b/installer/install.iss
@@ -2857,7 +2857,7 @@ begin
         '      {'+
         '        "guid": "{2ece5bfe-50ed-5f3a-ab87-5cd4baafed2b}",'+
         '        "name": "Git Bash",'+
-        '        "commandline": "'+AppPath+'/bin/bash.exe -i -l",'+
+        '        "commandline": "\"'+AppPath+'/bin/bash.exe\" -i -l",'+
         '        "icon": "'+AppPath+'/{#MINGW_BITNESS}/share/git/git-for-windows.ico",'+
         '        "startingDirectory": "%USERPROFILE%"'+
         '      }'+