-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(settlement): fixed submission bug where multiple events would cancel subscription #842
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 40.44% 39.86% -0.59%
==========================================
Files 120 119 -1
Lines 18935 18738 -197
==========================================
- Hits 7659 7469 -190
- Misses 10201 10220 +19
+ Partials 1075 1049 -26 ☔ View full report in Codecov by Sentry. |
@omritoptix there is a conflict |
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it would be good to simplify the big loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
…cel subscription (#842) Co-authored-by: Michael Tsitrin <[email protected]> Co-authored-by: Michael Tsitrin <[email protected]> Co-authored-by: danwt <[email protected]>
This PR solves few issues:
PR Standards
Opening a pull request should be able to meet the following requirements
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: