Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monkay integration #229

Merged
merged 14 commits into from
Nov 16, 2024
Merged

monkay integration #229

merged 14 commits into from
Nov 16, 2024

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Nov 13, 2024 •
edited
Loading

Changed:

  • Rework to use Monkay
  • FIx migration issues with ManyToMany fields

@devkral
Changes:
3ca4125 
- basic Monkay integration
- tests lazy imports
@devkral
Changes:
75fedff 
- port nearly completely to Monkay
- make EdgyExtra and Migrate stubs
@devkral
Changes:
060c2a0 
- complete monkay integration
@devkral devkral changed the title WIP: Devkral/feature/monkay integration monkay integration Nov 13, 2024
tarsil
tarsil previously approved these changes Nov 14, 2024
View reviewed changes
@tarsil
Copy link
Collaborator

tarsil commented Nov 14, 2024 •
edited
Loading

@devkral CI failing

@devkral
Changes:
a169170 
- fix get_engine_url_and_metadata
@devkral
Update tests to use the new monkay based way
61ed55c
@devkral
Changes:
6f404a7 
- update tests
 - migration tests are now harder
- update docs
@devkral
fix database used for template tests
dbb1000
@devkral
CHanges:
250d430 
- provide/update more docs
- add asgi import discovery
tarsil
tarsil approved these changes Nov 15, 2024
View reviewed changes
docs/edgy-people.md Outdated Show resolved Hide resolved
@tarsil
Copy link
Collaborator

tarsil commented Nov 15, 2024

CI failing and a comment to address. Sorry

tarsil
tarsil requested changes Nov 15, 2024
View reviewed changes
docs/edgy-people.md Outdated Show resolved Hide resolved
docs/migrations/discovery.md Outdated Show resolved Hide resolved
docs/settings.md Outdated Show resolved Hide resolved
edgy/__init__.py Show resolved Hide resolved
edgy/__init__.py Show resolved Hide resolved
@devkral
Changes:
8cdd856 
- fix extensions and preloads
@devkral
Changes:
26b3ef0 
- remove todo, and wording
@devkral
Changes:
f1350b5 
- fix typos and include @tarsild suggestions
@devkral
fix settings types
eb816f2
@devkral
Changes:
f21fb0e 
- bump version
- update release notes and docs
@devkral devkral requested a review from tarsil November 16, 2024 06:25
@tarsil
Copy link
Collaborator

tarsil commented Nov 16, 2024 •
edited
Loading

Make the stash message short, nice and easy please. Good job :)

@devkral devkral merged commit 848cad7 into main Nov 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarsil tarsil tarsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkral @tarsil