-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MegaLinter for Linting and Fixing #5
Conversation
Line Length has taken the standard of no new line characters except for paragraphs and relying on the developers/githubs soft line wraps for display |
Ive removed the dead workflow code and think the best way to move forward is to leave an issue on the repo linking to my question on the megalinter question. That way when there is a response we can update the repo workflow with an updated flow or append the example in megalinter. |
For removing the markdownlint.json we have some issues. I cant seem to override the default config without providing our own. The default is this
Personally I dont like the default as its not the actual default that markdownlint provides. Ive tried overriding it through the Im opting for us using our own config at the root level |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: ScottGibb <[email protected]>
MegaLinter has automatically applied linters fixes on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work
Summary
This PR aims to add Linting to the project via MegaLinter(https://github.com/oxsecurity/megalinter). The reason we want to use MegaLinter as it has a lot of out of the box setup and runs in docker so can be used cross platform and allows everyone to use the same linters.
Locally Running the Linter
This command will also auto format and fix various files as they are configured via the
.mega-linter.yml
file.Linting Workflow
This PR aims to fix both the codebase files and add the linting workflow.
The linting workflow at present works as follows:
On a Pull Request:
The Linting workflow will pass when all checked files have zero errors.
Due to some limitations in cargo clippy tool and rustfmt in MegaLinter an extra stage workflow was added to ensure full coverage.
Tasks
.markdownlint.json
is present )