If the bootstrap file is very large, the access token expires during a random batch download #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…downloading in a random batch. Added code for access token refresh
decrypto27
force-pushed
the
accessTokenRefreshInFlight
branch
from
686f46f to
9bb8ef4
Compare
danie20
reviewed
May 6, 2019
| String token = "foobar"; | ||
| try { | ||
| credentialLoader.loadCredentials(); | ||
| token = credentialLoader.getOauthResponse().getAccessToken().get().getToken(); |
There was a problem hiding this comment.
Prefer to check with expire time and add logic to get token.
credentialLoader.getOauthResponse().getAccessToken().get().getExpiresOn()
There was a problem hiding this comment.
ok. will make the required changes.
|
need to update pom version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAUTION: The credentials need to be set in the credentials.yml before usage.
This happens if we are using the examples for fetching the feed data. All in all, it is a useful change and makes the feed fetching a bit more resilient.