V1.0 tasks #230
Merged
V1.0 tasks #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the serialiser created more object than necessary in barebones profile mode as the setImportance method would override not set with a value of 10, but the equality check did not do this. This fix also fixes the serialiser tests.
on linux, this depends on other static initialisers having been ran (specifically the "text" constant in the XML parser), and they may end up running in the wrong order (the main change is in fonts.hpp; the rest is search/replace)
this was checked in the monitoring plugin, but not the scene plugin
this issues warnings about missing plist files, but works according to the VST3 specs the .vst3 should actually be a directory structure containing the library, but this works for now
this matches what the official JUCE cmake scripts do without this, all plugins end up sharing one message thread, which might be fine one some platforms, but on linux the VST wrapper assumes that there is a message thread for each plugin, and this ultimately causes callOnMessageThread callbacks to not get called unless the plugin window is open (specifically, it does something like using the run state of the messaging thread to decide whether to register with the VST event loop -- it's quite complicated and unclear) note that plugins are dlopened with RTLD_LOCAL, which you might think would stop this kind of sharing, but no -- the message thread is created with SharedResourcePointer, which is a template class and so the static variable lives in an inline function, which gets marked as "unique global", which still get merged it might be sensible to add this to the reaper_adm plugin and other libraries we use -- they mostly use static initialisation for caching so aren't affected by this, but it could cause issues when mixing plugins of different versions for debugging, for example
the user VST path does not end with "/VST3", so merge that into the prefix perhaps it would be better to make the full install dir somewhere centrally so that the VST3 part could be left out of the prefix on other platforms?
(tested in isolation but not in EPS code)
Uses the name string - this could be edited by the user in the plug-in selection window, but that breaks import due to TrackFX_AddByName not working either, so I don't think we need to try support that.
Means we can tidy up some code that used to call TrackFX_GetFXName
Quite a common use and prevents parsing state chunk repeatedly. Also made TrackFX_GetActualFXNameClean a more generic CleanFXName func.
Easier for testing parsing funcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other work: