Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the same vlan id on all the locators #1848

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

MarcelJordense
Copy link
Contributor

To use a specific vlan for a particular NetworkPartition then the vlan id is configured as part of the address (multicast) set for the NetworkPartition. This results in that the vlan id is set on the corresponding multicast locator. However it is not set on the unicast locator associated with the chosen ethernet interface.

@MarcelJordense
Copy link
Contributor Author

fixes #1834

Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MarcelJordense !

@eboasson eboasson merged commit 1f59974 into eclipse-cyclonedds:master Oct 9, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants