Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get matched publication crash #1853

Merged

Conversation

eboasson
Copy link
Contributor

Fixes #1851

@eboasson eboasson force-pushed the fix-get-matched-publication-crash branch from b5a3962 to 317784a Compare October 11, 2023 16:32
This crashed because the built-in topics are published by a "local
orphan writer" that is not contained in a participant, causing
dds_get_matched_publication_data to crash on dereferencing a null
pointer.

Signed-off-by: Erik Boasson <[email protected]>
@eboasson eboasson force-pushed the fix-get-matched-publication-crash branch from 317784a to 43560b9 Compare October 11, 2023 17:08
Copy link
Contributor

@dpotman dpotman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eboasson eboasson merged commit d6684dc into eclipse-cyclonedds:master Oct 12, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CycloneDDS crashes when a subscription matched listener is invoked on a reader for DCPSSubscriptions
2 participants