Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copyright date, efsl url, #33 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix copyright date, efsl url, #33 #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/src/main/asciidoc/license-efsl.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ document, or portions thereof, that you use:
* link or URL to the original Eclipse Foundation document.
* All existing copyright notices, or if one does not exist, a notice
(hypertext is preferred, but a textual representation is permitted)
of the form: "Copyright (c) [$date-of-document]
Eclipse Foundation, Inc. \<<url to this license>>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this substitution is required. It's meant as an example. By filling in the date and the specific url, then this might be used verbatim and it might not be accurate. At least by leaving the "substitution text" users would know what is expected. That's how I have been reading this section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, but it does seem like the EFSL license URL should be there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the generic form that has been used for all of the skeletal Specs as well as the Platform, Web Profile, and Managed Beans Specs. So, if it's decided that the url should be filled out explicitly, then all of the instances of this file would also need to be updated. I'd tend towards going for consistency than "correctness" at this point...

of the form: "Copyright (c) [{revdate}]
Eclipse Foundation, Inc. https://www.eclipse.org/legal/efsl.php"

Inclusion of the full text of this NOTICE must be provided. We
request that authorship attribution be provided in any software,
Expand Down