feat!: improve InteractionOutput implementation #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 65.37% 65.88% +0.50%
==========================================
Files 73 74 +1
Lines 2383 2389 +6
==========================================
+ Hits 1558 1574 +16
+ Misses 825 815 -10 ☔ View full report in Codecov by Sentry. |
JKRhb
force-pushed
the
output-value
branch
2 times, most recently
from
1b53930 to
95dede2
Compare
JKRhb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates some of the changes discussed in eclipse-thingweb/node-wot#1221 and w3c/wot-scripting-api#534 into the implementation of the
InteractionOutputinterface, while also aligning it a bit closer to the specification and improving both tests and documentation.There is still some work to be done, especially when it comes to the recent comments in w3c/wot-scripting-api#534, therefore at least one follow-up PR can be expected soon.