Make directory discovery a bit more robust #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
fix-tdd-discovery
branch
from
cf982ba to
f058053
Compare
JKRhb
force-pushed
the
fix-tdd-discovery
branch
from
481a214 to
d3e6b08
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 63.16% 63.26% +0.09%
==========================================
Files 79 79
Lines 2305 2311 +6
==========================================
+ Hits 1456 1462 +6
Misses 849 849 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, discovery via the
exploreDirectorymethod stops completely when an invalid TD is encountered during the discovery process.This PR changes the logic for deserializing the discovered TDs into
ThingDescriptionobjects, making the process a bit more reliable, as invalid TDs are just being skipped now.In order to help with debugging, one of the error message that is emitted during deserialization is also improved a bit and all errors during the directory discovery process will be logged via the developer tools.