Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read property set observe bug #26

Merged

Conversation

hidetak
Copy link
Contributor

@hidetak hidetak commented Jun 17, 2024

There was a bug in the process of setting observe for a Read Property node.

  • When a Read Property node is placed on the canvas, the configuration screen of the node is displayed, and the Thing is selected, one property is selected, but the observe checkbox is not displayed even if the property is observable.
  • When observe is true in Read Property and a non-observable property is selected, the observe checkbox is hidden, but observe remains true internally, so when the flow is deployed, an error message stating that it cannot be observed is displayed. After deploying a flow, an error message stating that the flow is unobservable will be output all the time.
  • When creating a flow from Create WoT Consumer flow, observe was true for the read-property node created, even though the property observable defined in the TD was false.
  • In flows generated by the Create WoT Consumer flow plugin, bool values were being converted using String(value), resulting in an error message stating that the type was different.Fixed to use JSON.parse(value) for conversion.

@egekorkan
Copy link
Member

Looks good on my side! Thanks @hidetak :)

I will do a PR to update the node-wot version and then we can make a new release.

@egekorkan egekorkan merged commit be3eeaf into eclipse-thingweb:main Jun 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants