chore(examples): enable eslint/strict-boolean-expressions and strictNullChecks #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpeintner
commented
Sep 22, 2023
| @@ -80,7 +80,7 @@ WoT.produce({ | |||
| const listToDelete = []; | |||
| for (const id of countdowns.keys()) { | |||
| const as = countdowns.get(id); | |||
| if (as !== undefined && as.output !== undefined) { | |||
| if ((as === null || as === void 0 ? void 0 : as.output) !== undefined) { | |||
There was a problem hiding this comment.
Interesting to see what the tool-chain makes out of
if (as?.output !== undefined) {
Note: This is not a change in this PR.. we might have forgotten to update the JS in a previous PR..
danielpeintner
commented
Sep 22, 2023
| @@ -396,7 +396,7 @@ Assumes one medium americano if not specified, but time and mode are mandatory f | |||
| const paramsp = (await params.value()) as Record<string, unknown>; // : any = await Helpers.parseInteractionOutput(params); | |||
|
|
|||
| // Check if uriVariables are provided | |||
| if (paramsp && typeof paramsp === "object" && "time" in paramsp && "mode" in paramsp) { | |||
| if (paramsp != null && typeof paramsp === "object" && "time" in paramsp && "mode" in paramsp) { | |||
There was a problem hiding this comment.
Note: What is also "interesting" here is that we cannot simply remove the
paramsp != null
check.
the following code
const paramsp = null;
if (typeof paramsp === "object") {
console.log("null is object")
}
prints null is object
|
any reviewer for this PR? It is a very simple one ;-) Note: Only the .ts files are of interest since the .js files are generated out of it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses one checkmark in #1046.