Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devDeps): upgrade eslint packages #1103

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Sep 30, 2023

In the context of #1097, I noticed that eslint currently reports a couple of false positives when it comes to typing. Furthermore, when running npm run lint, it warns of missing compatibility with the currently used TypeScript version.

This PR simply updates all of the eslint-related packages and applies some (partially automated) fixes to the codebase.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (49ad831) 75.52% compared to head (195c82b) 75.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1103   +/-   ##
=======================================
  Coverage   75.52%   75.52%           
=======================================
  Files          80       80           
  Lines       16153    16153           
  Branches     1520     1520           
=======================================
  Hits        12200    12200           
  Misses       3914     3914           
  Partials       39       39           
Files Coverage Δ
packages/binding-coap/src/coap-client.ts 82.28% <100.00%> (ø)
packages/binding-http/src/http-client-impl.ts 66.58% <100.00%> (ø)
packages/binding-http/src/oauth-manager.ts 98.26% <100.00%> (ø)
packages/core/src/consumed-thing.ts 83.37% <100.00%> (ø)
packages/core/src/helpers.ts 83.00% <100.00%> (ø)
packages/td-tools/src/thing-model-helpers.ts 84.41% <100.00%> (ø)
packages/binding-http/src/credential.ts 80.93% <0.00%> (ø)
...s/td-tools/src/util/asset-interface-description.ts 81.88% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this was very well needed.

@danielpeintner danielpeintner merged commit b51ef19 into eclipse-thingweb:master Oct 3, 2023
7 checks passed
@JKRhb JKRhb deleted the eslint-update branch October 3, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants