refactor(core): use private variables instead of function wrappers

[JKRhb]

As another addition to #1104, this PR replaces a couple of internal getters (that have been used for avoiding serialization) with built-in private variables, making the code a bit cleaner.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b51ef19) 75.52% compared to head (fcc3b70) 75.56%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
+ Coverage   75.52%   75.56%   +0.03%     
==========================================
  Files          80       80              
  Lines       16153    16154       +1     
  Branches     1520     1513       -7     
==========================================
+ Hits        12200    12207       +7     
+ Misses       3914     3908       -6     
  Partials       39       39              

Files	Coverage Δ
packages/core/src/consumed-thing.ts	83.94% <100.00%> (+0.57%)	⬆️
packages/core/src/exposed-thing.ts	67.58% <75.00%> (+0.42%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danielpeintner]

LGTM

Maybe it makes sense to add a comment why we use # but in this case I don't think I would do that since we would need to explain the rational all over the place.

I think it is good to go as is 👍

[JKRhb]

I tried to address your feedback, @danielpeintner, in fcc3b70, let me know if you see further room for improvement :)

[relu91]

were they included in the TD? I've never noticed, otherwise, the comment is a little bit misleading.

[JKRhb]

were they included in the TD? I've never noticed, otherwise, the comment is a little bit misleading.

The result is basically the same as before, the only difference is that we do not need the getter construction anymore. We could also remove the comments as it is common JS behavior, I guess it depends on how useful the reminder of this behavior is.

[danielpeintner]

Note: We used to have the workaround to wrap the internal state into functions to not be stringified in a TD. The current approach using private variables is much better in my regard. Hence I think the comment is fine 🤷‍♂️