Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(td-tools): Aid updates #1107

Merged
merged 5 commits into from
Oct 11, 2023
Merged

refactor(td-tools): Aid updates #1107

merged 5 commits into from
Oct 11, 2023

Conversation

danielpeintner
Copy link
Member

  • use lowercase interaction name
  • rework README and put focus on AID submodel usage

@danielpeintner danielpeintner requested a review from relu91 as a code owner October 9, 2023 13:29
JKRhb
JKRhb approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, just spotted one nit in the aid-to-td example.

packages/td-tools/src/util/README.md Outdated Show resolved Hide resolved
@danielpeintner danielpeintner merged commit 1f71e3f into eclipse-thingweb:master Oct 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKRhb JKRhb JKRhb approved these changes

@relu91 relu91 Awaiting requested review from relu91 relu91 is a code owner

@sebastiankb sebastiankb Awaiting requested review from sebastiankb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielpeintner @JKRhb